Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban Board #8

Open
peterdtitan opened this issue Jul 6, 2023 · 3 comments
Open

Kanban Board #8

peterdtitan opened this issue Jul 6, 2023 · 3 comments

Comments

@peterdtitan
Copy link
Owner

Below is the link to the Kanban Board for this project:

Recipe App: Kanban Board

This is a 2-person project and the authors are:
@peterdtitan
@Santosh-Konappanavar

@KDlamini
Copy link

KDlamini commented Jul 6, 2023

Hi team @peterdtitan, @Santosh-Konappanavar 🙋‍♀️,

Great work so far! 💯
You have done a great job creating a Kanban board to divide tasks amongst team members. 🎊 🥳
There are some issues that you still need to work on improving your project according to the requirements. You are almost there! 💪🏾

Highlights 🌞

✔️ Professional issues page with a link to the project and team info
✔️ Each card on the board has a title, description, and number of points
✔️ The board has four columns To Do, In Progress, In Review, and Done
✔️ All cards are assigned to team members

Required Changes ♻️

-Please make sure that all tasks in the project requirements have a task. Each requirement should have at least one corresponding card on the Kanban board.

For example, instead of just having one task for all the views. You can divide all the page views amongst teammates and assign each page to a team member.
Each of the following points should be a task assigned to a team member.

  • [TASK - Login page and registration page]:
    • Should be built with Devise.
  • [TASK - Navbar]: Create a navigation menu that allows users to open all of the pages you created.
  • [TASK - Food list (only for a group that has less than 3 members)]:
    • Should display a list of food added by the logged-in user as in the wireframe (display also quantity of a given food).
    • Should lead to a form that allows users to add new food.
  • [TASK - Recipes list]:
    • Should display a list of recipes created by the logged-in user as in the wireframe.
    • Should lead to recipe details.
    • If the user is the owner of the recipe, should allow the user to delete it.
  • [TASK - Public recipe list]:
    • Should display a list of all public recipes ordered by the newest as in the wireframe.
    • Should lead to recipe details.
  • [TASK - Recipe details]:
    • Should display a toggle button that allows for a recipe to be made public or private.
    • If the recipe is public or the user is the owner of the recipe, should display the recipe details as in the wireframe.
    • If the user is the owner of the recipe, should lead to the form that allows the user to add new food.
  • [TASK - General shopping list view (only for a group that has less than 3 members)]:
    • Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user).
    • Should count the total food items and total price of the missing food.
  • [TASK - Peformance]: Make sure there are no N+1 queries happening.

Cheers 🥂 and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @KDlamini in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@peterdtitan
Copy link
Owner Author

Done and resolved ✅ ✅

@muneebulrehman
Copy link

Hi team,

Your project is complete! 🥳
Congratulations! 🎉

Status: Approved✔️

Highlights

  • No linter errors
  • Descriptive PR
  • Great job adding the missing tasks to the Kanban board
  • Great follow-up with the previous reviewer.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants