Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing the window reveals hidden values (passwords) #142

Closed
ghost opened this issue Nov 19, 2020 · 1 comment
Closed

Resizing the window reveals hidden values (passwords) #142

ghost opened this issue Nov 19, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 19, 2020

Regardless the operating system, we noticed that liner library reveals hidden values when the screen gets too narrow for both the label and input space of a hidden variable.

The method
func (s *State) tooNarrow(prompt string) (string, error)

calls func (s *State) promptUnsupported(p string) (string, error)
which then calls
linebuf, _, err := s.r.ReadLine() !!!
When this happens a hidden value is not hidden anymore.

@peterh peterh closed this as completed in ab0ba8d Nov 20, 2020
@peterh
Copy link
Owner

peterh commented Nov 20, 2020

Thanks for the bug report. Should be fixed in master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant