Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and grammatical errors #26

Merged
merged 6 commits into from Oct 28, 2022
Merged

Fix typos and grammatical errors #26

merged 6 commits into from Oct 28, 2022

Conversation

maxwellward
Copy link
Collaborator

Changes:

  • Changes "google analytics" to "Google Analytics", as it's the name of a brand.
  • Removes extra padding around links in the privacy banner.
  • Adjusting the wording of some statistics to flow better and be grammatically correct.

Looking for feedback on the following changes:

  • Changing the "Read more" link on the privacy banner to its own button next to "Continue"
  • Changed "is available for self hosting." text in privacy banner to "is available for analysis or self hosting."

I've also made a list of statistics that don't seem accurate or don't make sense and I will ask Discord about them and share the results.

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for discordpackage ready!

Name Link
🔨 Latest commit 4eae798
🔍 Latest deploy log https://app.netlify.com/sites/discordpackage/deploys/635c17408c32350008cf163a
😎 Deploy Preview https://deploy-preview-26--discordpackage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@peterhanania
Copy link
Owner

I’ve just reviewed your code and everything seems good. Your code is well changed and your ideas are good. Thank you for your contribution. Regarding the analytics being inaccurate, I mean don’t expect them to be fully accurate because no one knows how they’re even collected. I will merge your contribution anyways. DM me to claim your contribution role on the discord server.

Copy link
Owner

@peterhanania peterhanania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterhanania peterhanania merged commit 7d4f963 into peterhanania:main Oct 28, 2022
@maxwellward
Copy link
Collaborator Author

Thanks to for merging! Regarding the inaccuracies, I meant I'll ask Discord how they're collected so we can decide if they should be shown or not. Maybe they could be put into a "legacy" category if they're not being tracked anymore?

@peterhanania
Copy link
Owner

Let’s wait and see🙂

@maxwellward maxwellward deleted the fix-typos branch October 30, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants