Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #129 #130

Merged
merged 2 commits into from May 17, 2020
Merged

Fix for issue #129 #130

merged 2 commits into from May 17, 2020

Conversation

StephanWagner
Copy link
Contributor

The function getBoundingClientRect() might return 0 for width or height when the element is an inline element. Setting a display type inline-block fixes this.

@StephanWagner
Fix for issue #129
95bff5c 
The function getBoundingClientRect() might return 0 for width or height when the element is an inline element.
@StephanWagner StephanWagner mentioned this pull request Apr 24, 2020
Closed
@peterhry
Copy link
Owner

Thanks. Can you please bump the version in package.json to 2.3.2 and rebuild the dist?

@StephanWagner
Copy link
Contributor Author

Version update pushed to master.

@peterhry peterhry merged commit b10ddbc into peterhry:master May 17, 2020
@peterhry
Copy link
Owner

Thanks @StephanWagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StephanWagner @peterhry