Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick test on latest FF #23

Closed
eikaramba opened this issue Feb 9, 2022 · 4 comments · Fixed by #30
Closed

quick test on latest FF #23

eikaramba opened this issue Feb 9, 2022 · 4 comments · Fixed by #30
Labels
bug Something isn't working

Comments

@eikaramba
Copy link

Tested on FF 96

  • Links not working (i cannot open a link, only delink a text)
  • when reordering images i get a duplicated image in the new and old spot.
@jeregrine
Copy link

Confirmed on 97.0 (64-bit) macOS 12.3 beta

@peterpeterparker
Copy link
Owner

Thanks! agree on both, can reproduce with FF 97 too.

The image reordering happens in Chrome too.

@peterpeterparker peterpeterparker added the bug Something isn't working label Feb 10, 2022
@peterpeterparker
Copy link
Owner

Links:

  • creating links on Firefox should now be fixed
  • removing links works too however I am not able to preserve the styles (colors etc.) of the children when I do so. It works in Safari and Chrome but not in FF. Seems the selection API behaves differently on FF. I can live with it. If you want to give a try, that's the removeLink function.

@peterpeterparker
Copy link
Owner

Img cloned on drag: solved

Super cool stuffs, fixing this issue forced me to develop two improvements I had in mind for a long time 😁.
Therefore thanks a lot, it really pushed forward the library!

Let me know if does not work out or if it needs other fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants