-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No rings error on intersection error #569
Comments
Thanks for the detailed bug report @angaither. It's interesting that the bug occurs on There's nothing "weird" or degenerate etc. going on with the inputs, so this is a case that I definitely want to get working correctly. ![]() I suspect it's got something to do with the DCEL noding step -- I'll see if I can work out what's going on. |
If it helps, I've got a few more failing test case examples:
|
Thanks! Those will be useful as additional regression tests once I've got the bug sorted out. |
A fix for this has been released in v0.46.0. |
I think we have a faulty dcel ring extraction.
Given two valid geometries, an intersection should return.
Here is a test that should pass in both cases against the latest tag v0.45.1 however the first example fails due to "no rings to extract"
When the geometry is simplified to 6 floating decimal points (second test case) an intersection is returned.
I believe it is related to the issue mentioned in this commit
I added the following test to
geom/alg_set_op_test.go
this is failing on
go version go1.20 darwin/amd64
but weirdly enough will pass on
go version go1.20.5 darwin/arm64
The text was updated successfully, but these errors were encountered: