Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating point precision errors showing up in league stats page #17

Closed
PeteyPii opened this issue Nov 10, 2014 · 1 comment
Closed

Floating point precision errors showing up in league stats page #17

PeteyPii opened this issue Nov 10, 2014 · 1 comment
Labels
bug

Comments

@PeteyPii
Copy link
Owner

Instead of saying a summoner has 29.01 points it'll say they have 29.0999999998 points (or similar). This is due to CS counting as 0.01 points... We should probably round to 2 decimal places and also make sure that when stats get large, errors are not introduced by multiplying by 0.01.
@PeteyPii PeteyPii added the bug label Nov 10, 2014
@PeteyPii
Copy link
Owner Author

Fixed by using Python's decimal module. We should have exact decimal numbers for whatever scoring system we want to use.

b780281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PeteyPii