Floyd-Warshall #377
Merged
Floyd-Warshall #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teuron
reviewed
Feb 21, 2021
teuron
reviewed
Feb 21, 2021
|
I don't know why rustfmt check is failing. |
|
(Coming from the Reddit post about prepona.) I tried running |
|
Hi! The rustfmt errors in master where fixed in 56feb0b. They should be fixed if you rebase. |
|
Hi! I'll do it today. Thanks for your help. |
put BoundedMeasure trait alongside Measure trait implement BoundedMeasure trait for all numerical types. add unit test for floyd_warshall algorithm move floyd warshall tests into tests/floyd_wrashall.rs replace panic with Result return type handle overflow and underflow more elegantly add quickcheck for floyd_warshall algorithm add documentation for floyd_warshall algorithm add link to wikipedia for floyd_warshall algorithm use std types instead of primitives update test and doc update tests again! Update src/floyd_warshall.rs Co-authored-by: Lukas Abfalterer <labfalterer@gmail.com> Update src/algo/mod.rs Co-authored-by: Lukas Abfalterer <labfalterer@gmail.com> apply cargo fmt
ABorgna
approved these changes
May 1, 2021
There was a problem hiding this comment.
This looks nice, thanks!
It's a pity that it cannot be used with StableGraph (due to the compactness trait), but changing the index iteration to iterating over node indices would probably kill the efficiency.
Do you thing you could add a benchmark for this?
This can be merged as-is either way :)
|
Sure. I'll add it till the end of this week. |
teuron
pushed a commit
to teuron/petgraph
that referenced
this pull request
Oct 9, 2022
* implement floyd_warshall algorithm and expose it via algo module put BoundedMeasure trait alongside Measure trait implement BoundedMeasure trait for all numerical types. add unit test for floyd_warshall algorithm move floyd warshall tests into tests/floyd_wrashall.rs replace panic with Result return type handle overflow and underflow more elegantly add quickcheck for floyd_warshall algorithm add documentation for floyd_warshall algorithm add link to wikipedia for floyd_warshall algorithm use std types instead of primitives update test and doc update tests again! Update src/floyd_warshall.rs Co-authored-by: Lukas Abfalterer <labfalterer@gmail.com> Update src/algo/mod.rs Co-authored-by: Lukas Abfalterer <labfalterer@gmail.com> apply cargo fmt * add benchmark for floyd warshall algorithm * apply cargo fmt
teuron
pushed a commit
to teuron/petgraph
that referenced
this pull request
Oct 9, 2022
* implement floyd_warshall algorithm and expose it via algo module put BoundedMeasure trait alongside Measure trait implement BoundedMeasure trait for all numerical types. add unit test for floyd_warshall algorithm move floyd warshall tests into tests/floyd_wrashall.rs replace panic with Result return type handle overflow and underflow more elegantly add quickcheck for floyd_warshall algorithm add documentation for floyd_warshall algorithm add link to wikipedia for floyd_warshall algorithm use std types instead of primitives update test and doc update tests again! Update src/floyd_warshall.rs Co-authored-by: Lukas Abfalterer <labfalterer@gmail.com> Update src/algo/mod.rs Co-authored-by: Lukas Abfalterer <labfalterer@gmail.com> apply cargo fmt * add benchmark for floyd warshall algorithm * apply cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements floyd_warshall algorithm