Switch from travis to github actions for CI #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustfmt didn't run correctly in previous travis setup. Here it runs, but the format check fails. I've set it to an allowed failure for now - still visible on the PR. |
jrraymond
approved these changes
Jan 9, 2021
|
Thanks |
|
As noted - the running of rustfmt is fixed. It's marked wiht "continue-on-error" for rustfmt. Fixing can be a different PR. Existing PRs will need to rebase onto master to get the new github actions CI. (Edit: Maybe this is not needed! Just pushing something new to whatever branch could work). |
|
I'm integrating this without merge commit - not my preference but I believe that's what @XVilka prefers? |
|
Precisely, thank you!
…On Sun, Jan 10, 2021, 08:31 bluss ***@***.***> wrote:
I'm integrating this without merge commit - not my preference but I
believe that's what @XVilka <https://github.com/XVilka> prefers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRT7NPV77TLT42PS5IR5LSZDYMRANCNFSM4VZSUC2Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy setup from matrixmultiply and adapt to do the same test as the old travis test. Also fixes the running of rustfmt (but not fixing the formatting in this PR).
Fixes #390