Implement Debug and Clone for iterators #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 24, 2021 13:28
…xternals` iterators.
…nd `graphmap` as I could
ABorgna
approved these changes
Apr 25, 2021
There was a problem hiding this comment.
adj::EdgeIndices is missing a derive.
Lgtm. If we detect any other missing trait later it can be added in a minor revision.
|
@ABorgna thanks! Seems like I missed that, but now it's there. |
teuron
pushed a commit
to teuron/petgraph
that referenced
this pull request
Oct 9, 2022
* Implement Clone and Debug for `graph::Externals` and `stable_graph::Externals` iterators. * Add Debug and Clone to as many iterators in `graph`, `stable_graph` and `graphmap` as I could * Add Debug and Clone to iterators in `matrix_graph` * Add Debug and Clone to iterators in `adj`, `csr` and `data` * Add Debug and Clone to iterators in `algo` and `visit` * Add Debug and Clone to `stable_graph::NodeReferences` * Add comments to few iterators that I couldn't implement Debug and Clone on * Add Debug and Clone to `adj::EdgeIndices` Co-authored-by: Zalli <>
teuron
pushed a commit
to teuron/petgraph
that referenced
this pull request
Oct 9, 2022
* Implement Clone and Debug for `graph::Externals` and `stable_graph::Externals` iterators. * Add Debug and Clone to as many iterators in `graph`, `stable_graph` and `graphmap` as I could * Add Debug and Clone to iterators in `matrix_graph` * Add Debug and Clone to iterators in `adj`, `csr` and `data` * Add Debug and Clone to iterators in `algo` and `visit` * Add Debug and Clone to `stable_graph::NodeReferences` * Add comments to few iterators that I couldn't implement Debug and Clone on * Add Debug and Clone to `adj::EdgeIndices` Co-authored-by: Zalli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to implement the Debug and Clone traits for
graph::Externals(#416), but when looking at the source code I noticed that many iterator types didn't implement them either even when they could. So I went over every iterator type that I could find and added those implementations to where I could.3 iterators that I found used an internal iterator that didn't implement them both so I skipped them but added a comment. They could be solved by making them a custom iterator but I feel like that's out of scope for this PR.
Fixes #416