Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV for release 0.6 #428

Closed
ABorgna opened this issue May 14, 2021 · 5 comments
Closed

Bump MSRV for release 0.6 #428

ABorgna opened this issue May 14, 2021 · 5 comments
Milestone

Comments

@ABorgna
Copy link
Member

ABorgna commented May 14, 2021

Since we are planning on doing a major release, we can update the Minimum Supported Rust Version (current one is 1.37).

Should we go for 1.40? Anyone proposes something more recent?

@ABorgna ABorgna added this to the 0.6 milestone May 14, 2021
@mtreinish
Copy link
Contributor

If possible could we avoid going above 1.41 (so 1.40 works quite well for me)? 1.41 is the version of rustc that debian buster is currently shipping and at least for some of my downstream user base it's very important to be able to compile the library I maintain that's built on petgraph with the debian version of rustc.

@ABorgna
Copy link
Member Author

ABorgna commented May 16, 2021

Another datapoint:

  • The no_std feature (NO_STD #370) will add hashbrown as a dependency, which has a MSRV of 1.49. hashbrown0.9.1 (from 2020-09-28) still supported 1.36, so we'd have to use that version if we keep to something lower.

@ABorgna
Copy link
Member Author

ABorgna commented May 16, 2021

@mtreinish
Copy link
Contributor

Unless you actually require the latest version (for api compatibility reasons, new features, or something else) you can just set a version range, something like: https://github.com/PyO3/pyo3/blob/main/Cargo.toml#L30. That way downstream crates that use it can use the version that meets their constraints. I actually use hashbrown in my crate (for the rayon iterator support) but have it fixed at 0.9 for rustc 1.41 support.

@ABorgna
Copy link
Member Author

ABorgna commented Jun 27, 2021

I set the new version to 1.41 :)
We'll deal with the new indexmap and hashbrown versions when we need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants