hanging while trying to run Dart tests

[kevmoo]

dart --checked test/dart_test.dart

Curious if you're seeing this.

I'm on the latest integration build 0.5.1.0 r22072

[renggli]

Yeah, I've seen that too. I seemed to have happened with the recent changes to CompositeParser2 that were necessary because of the introduction of Symbol in InvokationMirror. Not sure exactly what the problem is. Looks like CompositeParser2 does not work properly anymore.

That's also the reason why I moved CompositeParser2 to a beta package to discourage people from using it. I hope you are not yet depending on it? Also not sure what your opinion on the magic of CompositeParser2 is? For me it looks cool to be able to refer to productions using variable names, but the warnings of the editor annoy me.

I wil try to investigate the problem the coming weekend. In the meantime, if you see a fix feel free to send me a pull request.

[kevmoo]

My haml impl needs to evaluate Dart expressions.

As a work-around, I've been copying from you using the old format

https://github.com/kevmoo/haml.dart/blob/master/lib/dart_grammar.dart

I'd love to have one impl of a Dart parser.

If I get an itch, I'll see if I can help you debug.

[kevmoo]

So.

There seems to be a bug in the collection classes...or I'm blind.

I added the following

    _todo.forEach((i) {
      assert(!_done.contains(i));
    });

to _ParserIterator and the assert fails. Some how dupes are getting added to _todo.

I hacked around the issue to fix the assert and notice that this never seems to settle down.

The iteration gets into 1000 "done" items with no hint of finishing.

Possible bug in the grammar?

[renggli]

I close this issue, as we do not remove duplicates any longer from composite grammars, so the described problem is gone. I created Issue 11 to track the (strangely) slow performance of removeDuplicates(Parser).