Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

petitparser on maven central #15

Closed
McFoggy opened this issue Nov 5, 2018 · 9 comments
Closed

petitparser on maven central #15

McFoggy opened this issue Nov 5, 2018 · 9 comments
Assignees

Comments

@McFoggy
Copy link

McFoggy commented Nov 5, 2018

I know that #5 has been closed because of jitpack deployment but I would really like that you reconsider to publish the library on maven central.

Like you I provide some OSS libraries ; one of them is jgitver which consist of 3 projects:

  • a library jar using java-petitparser; built with maven
  • a maven plugin as a core maven extension; built with maven
  • a gradle plugin; built with gradle

The problem of jitpack, is as being a non standard repository, end users of plugins/libs have to declare in their build tool the usage of jitpack even if they just use 'plugins' and not directly your library.

This means for jgitver plugins that jitpack has to be present not just in the standard dependencies scope but also in the plugin dependencies scope:

  • thus a specific pluginRepositories setting for maven
  • a specific buildscript>repositories setting for gradle

Having java-petitparser in central would just be transparent for any one using it anywhere in anytool.

Like many others I personally publish to central via sonatype. If you follow the instructions there (https://central.sonatype.org/pages/ossrh-guide.html) it is a no brainer.

Without a deployment to central, I see only 2 possibilities for me:

  1. refactor to remove the usage of java-petitparser
  2. fork, relocate under fr.brouillard.oss, and publish to central so that it is available out of the box as a resolvable dependency in maven & gradle.

I am going to do 2. right now otherwise I cannot publish my latest version of the gradle plugin but I would really prefer to avoid any of the 2 mentioned possibilities.

Thanks for your understanding.

@McFoggy
Copy link
Author

McFoggy commented Nov 5, 2018

FYI I forked here https://github.com/jgitver/java-petitparser/tree/jgitver and just pushed

<groupId>fr.brouillard.oss.com.github.petitparser</groupId>
<artifactId>petitparser-core</artifactId>
<version>2.1.0-jgitver</version>

It will find its way to central in the following minutes/hours once the synchronization between sonatype & central occur.

@renggli
Copy link
Member

renggli commented Nov 5, 2018

Thank you, I'll give it another try to publish to Maven Central and let you know how it goes. Your changes and the links to working documentation will certainly help. Hopefully, things are simpler in the meantime :-)

@renggli renggli self-assigned this Nov 5, 2018
@McFoggy
Copy link
Author

McFoggy commented Nov 5, 2018

Perfect thank you for your reconsideration.

@renggli
Copy link
Member

renggli commented Nov 5, 2018

Created a new project ticket: https://issues.sonatype.org/browse/OSSRH-43881

@renggli
Copy link
Member

renggli commented Nov 5, 2018

Managed to run mvn -Poss -DskipTests deploy.

@McFoggy
Copy link
Author

McFoggy commented Nov 5, 2018

I see it on Sonatype repo https://oss.sonatype.org/content/groups/public/com/github/petitparser/petitparser-core/2.2.0/

It should be on its way to central.

@renggli
Copy link
Member

renggli commented Nov 6, 2018

Is there anything else I can / should do?

@McFoggy
Copy link
Author

McFoggy commented Nov 6, 2018

no perfect, your lib is on central

image

@McFoggy McFoggy closed this as completed Nov 6, 2018
@renggli
Copy link
Member

renggli commented Nov 7, 2018

Thank you for your help and your pushing on getting it there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants