Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Official recommendation for using Bluebird with async functions? #1434
Hello folks. First off I recognize that (despite your support guidelines) I am asking a support question, that has already received an answer on Stack Overflow. But a disadvantage of that channel is that I can't tell if that's an "official" recommendation or just some random user trying to be helpful.
I also feel like this discussion should be documented somewhere on bluebirdjs.com, whereas currently async functions don't get any mention there. (Closest is a mention of C#'s
So—do the Bluebird maintainers have any position on the best way to use Bluebird with
Related: #1426 (comment).
Basically, over the years we've added to the platform all the features that made native promises awful back then (swallowing errors) and from the other side there has been a lot of effort from V8 to optimize native promises and from platforms to provide stable APIs for them.
My recommendation would be to use bluebird for collection methods and when you need performance over async functions (that might change) while you should likely use native promises for everywhere else.
The big pain points bluebird aimed to solve were addressed by native promises. Bluebird still has very useful APIs (like promisification of a whole module, cancellation or collection methods).
Other than that - prefer native promises. They are the future. There is no official way to use bluebird promises with async/await - (there was a proposal for that that was for observables but would have worked with bluebird - it got turned down). Using a babel plugin works - but if you care about performance Babel isn't great anyway.
Bluebird has 17.5 million downloads a month - I hope the native platform gets good enough to get those numbers down - and we're working on it :)
Thanks for the thoughtful response @benjamingr! That's great to hear that you don't consider the performance differences to be a blocker or insurmountable, it seems like your response runs a bit counter to earlier comments from Bluebird folks ("Even if V8 implemented the same optimizations as bluebird, it would still be hindered by specification.")
Oh interesting, is async/await with native promises faster than generators i.e.
Btw is there anything from the above that you'd like to add to somewhere in the documentation? Glad to put up a PR if so.
The situation when ES6 promises were introduced was that they were not really usable. Petka implemented unhandled rejection detection in Node a year and a half ago, the default was changed to warning about a year ago, and
It's better, bluebird still probably provides better developer experience in most cases but it's not clear cut.
@wearhere we fixed that by adding
This literally took changing the platform. It was a hard battle that took us years of convincing.
Bluebird.coroutine is still likely faster - but note that TurboFan can do optimizations that bluebird cannot with async functions - and over time it will get better. For example it can detect you await a value that's already resolved to a value and optimize that into just replacing your code with the value.
I'm not sure about the documentation.
Super cool, thanks for the information @benjamingr, and for your / the other maintainers' hard work over the years to get the platform to this point!
That's cool on the docs, just wanted to offer in return for you posting everything here. :) Closing for now then.