Promise.reject(reason) often fires and ignores exceptions -- not debug friendly

[jparker-hbo]

The docs say "Promise.reject(dynamic reason) -> Promise" but the code does this:

function markAsOriginatingFromRejection(e) {
    try {
        notEnumerableProp(e, "isAsync", true);
    }
    catch(ignore) {}
}
function notEnumerableProp(obj, name, value) {
    var descriptor = {
        value: value,
        configurable: true,
        enumerable: false,
        writable: true
    };
    es5.defineProperty(obj, name, descriptor);
    return obj;
}

So if "reason" is undefined or something that can't have a property defined like a string literal, then it throws and ignores it.

This doesn't crash, but if you're using "pause on all exceptions" in Chrome, it's annoying. Also, then the "isAsync" property won't exist... does that cause problems later?

If you like the existing behavior, then the docs should change to say that "reason" needs to be an object.

[petkaantonov]

By spec a promise rejection reason can technically be a non-error like a string or a number or other absurd value but the non-spec extensions like .error() don't support this. See show/02738964b9a97571a53ee65905b59c4debce57ec/88333ba#diff-88333ba11114e014e87198d04680144d

I guess notEnumerableProp could add a check to avoid throwing for that case