Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove eval optimization that causes unreachable code warning in Firefox. #1504

Closed
Giwayume opened this issue Feb 16, 2018 · 5 comments

Comments

@Giwayume
Copy link

  1. What version of bluebird is the issue happening on?
    3.5.1

  2. What platform and version?
    Firefox 58.

  3. Did this issue happen with earlier version of bluebird?
    Yes

I realize why this optimization exists. #899 #1234

I am requesting you only provide this optimization in the minified bluebird.min.js (for those looking for performance improvements), and leave it out of bluebird.js (for those looking for a proper spec-compliant library without compiler hacks). I am tired of seeing the warning message.

@gabrielps

This comment has been minimized.

@mdr1384
Copy link

mdr1384 commented Jan 7, 2022

I disagree. Some of us do our own minification because we combine dozens of JS files together to get a single JS file for the entire page, and we get better compression when all the unminified files are concatenated first. We would lose the "optimization" if you didn't put it in the unminified version. I don't understand why anyone cares about the warning if it only happens in dev mode.

@Giwayume
Copy link
Author

Giwayume commented Jan 7, 2022

I don't personally care how it's done, I'm just asking for the option with it removed. You don't agree with losing a compiler hack, I don't agree with having compiler hacks in the first place that are supposed to be bad code on paper. Compilers change and ultimately the spec drives it.

@benjamingr
Copy link
Collaborator

This was actually fixed a while ago when we made toFastProperties work with new v8

@Giwayume
Copy link
Author

Giwayume commented Jan 7, 2022

Alright

@Giwayume Giwayume closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants