TypeError when a filter in catch handler is not a function

[marijaselakovic]

1. What version of bluebird is the issue happening on?
   3.5.1

2. What platform and version? (For example Node.js 0.12 or Google Chrome 32)
   Node.js v8.5, Ubuntu 16.04.4

3. Did this issue happen with earlier version of bluebird?
   Not sure

If a non-function value is passed as a filter to catch I get the following error: TypeError: Cannot read property 'apply' of undefined
The following code demonstrates this:

var p2 = Promise.reject(10);
p2.catch(function(){return true},undefined)

You should consider adding a type check on arguments passed to catch.

[benjamingr]

@marijaselakovic honestly I just use TS which catches that - a PR is welcome I believe though.

cc @petkaantonov

[marijaselakovic]

Sure, PR 1518

[benjamingr]

@marijaselakovic sure, can you add a test to the PR that shows the difference in the error thrown?

[marijaselakovic]

Yes, I added the test, which would fail in both versions, but you can see the difference in error messages. Not sure if that's enough