Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script error in shedule.js in IE9/Win7 #1591

Closed
zzcypc opened this issue Apr 18, 2019 · 1 comment
Closed

Script error in shedule.js in IE9/Win7 #1591

zzcypc opened this issue Apr 18, 2019 · 1 comment

Comments

@zzcypc
Copy link

@zzcypc zzcypc commented Apr 18, 2019

Ping @KarolBuchta - please comment if you have additional info

I can't reproduce this without using a faulty polyfill. I recommend you try including bluebird first and any polyfills second.

Originally posted by @benjamingr in #1236 (comment)

@zzcypc
Copy link
Author

@zzcypc zzcypc commented Apr 18, 2019

In the case where the page first included the MutationObserver polyfill, in IE9, an exception will be thrown because the classList does not exist. I think that we should judge the existence of the classList at the same time as we judge the existence of the MutationObserver, which can cover more usage scenarios and the code can be more robust.

https://github.com/petkaantonov/bluebird/blob/master/src/schedule.js#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant