We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quite a mystery but bluebird performs 100x worse in various microbenchmarks by @stefanpenner after introducing custom builds in 0.9.3
Before that commit:
bluebird def x 1,564,555 ops/sec ±1.67% (68 runs sampled)
After:
bluebird def x 20,000 ops/sec ±1.67% (68 runs sampled)
While this is a low quality benchmark such radical change still worries me:
//Async test function make() { var resolver = Promise.pending() resolver.fulfill() return resolver.promise } make().then(function () { deferred.resolve() })
Only the node.js macrobenchmark are currently used to test for performance regressions so that's how these were missed.
The text was updated successfully, but these errors were encountered:
Fixed in 2c51568
Sorry, something went wrong.
No branches or pull requests
Quite a mystery but bluebird performs 100x worse in various microbenchmarks by @stefanpenner after introducing custom builds in 0.9.3
Before that commit:
bluebird def x 1,564,555 ops/sec ±1.67% (68 runs sampled)
After:
bluebird def x 20,000 ops/sec ±1.67% (68 runs sampled)
While this is a low quality benchmark such radical change still worries me:
Only the node.js macrobenchmark are currently used to test for performance regressions so that's how these were missed.
The text was updated successfully, but these errors were encountered: