Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microbenchmark performance 100x slower #33

Closed
petkaantonov opened this issue Nov 28, 2013 · 1 comment
Closed

microbenchmark performance 100x slower #33

petkaantonov opened this issue Nov 28, 2013 · 1 comment

Comments

@petkaantonov
Copy link
Owner

Quite a mystery but bluebird performs 100x worse in various microbenchmarks by @stefanpenner after introducing custom builds in 0.9.3

Before that commit:

bluebird def x 1,564,555 ops/sec ±1.67% (68 runs sampled)

After:

bluebird def x 20,000 ops/sec ±1.67% (68 runs sampled)

While this is a low quality benchmark such radical change still worries me:

//Async test
function make() {
  var resolver = Promise.pending()

    resolver.fulfill()

  return resolver.promise
}


make().then(function () { deferred.resolve() })

Only the node.js macrobenchmark are currently used to test for performance regressions so that's how these were missed.

@petkaantonov
Copy link
Owner Author

Fixed in 2c51568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant