Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling cancel more than once synchronously causes weird behavior #362

Closed
nomcopter opened this issue Oct 23, 2014 · 0 comments
Closed

Calling cancel more than once synchronously causes weird behavior #362

nomcopter opened this issue Oct 23, 2014 · 0 comments

Comments

@nomcopter
Copy link

@nomcopter nomcopter commented Oct 23, 2014

Adding the following tests to test/mocha/cancel.js demonstrates this behavior. With delay passes while Without delay fails.

describe("Cancelling a promise twice should have no additional effect", function() {
    specify("With delay", function(done) {
        var promise = pending().promise.cancellable().catch(function(){}).then(done).catch(function() { done(new Error('Should not be called')) });
        promise.cancel();
        setTimeout(function() {
            promise.cancel();
        }, 50);
    });
    specify("Without delay", function(done) {
        var promise = pending().promise.cancellable().catch(function(){}).then(done).catch(function() { done(new Error('Should not be called')) });
        promise.cancel()
        promise.cancel();
    });
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.