Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPromise.timeout() leaks a promise reference after resolution/rejection #371
Comments
petkaantonov
closed this
in
70dc544
Oct 31, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
nomcopter
commented
Oct 31, 2014
|
Man that turn around time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
henryptung commentedOct 30, 2014
Since timeout() uses window.setTimeout() but does not clearTimeout() on resolution/rejection, a handle to the promise (and its resolution data) is leaked in the window for the duration of the timeout, even if the request is rapidly resolved. When the rate of data transfer is very high, this causes the browser to OOM and crash within minutes.
We use promises in the context of requests that have a vastly variable range of latency and transfer speed (between milliseconds and tens of minutes) due to unpredictable network/operational conditions. Promise.timeout() can handle this with a sufficiently large timeout setting, but this causes problems under very low latency conditions.