Unable to chain promisifyAll request function

[jhnlsn]

var Promise   = require('bluebird'),
    request   = Promise.promisifyAll(require('request'))
Promise.props({"url":"http:google.com"}).then(request.getAsync).spread(function(response, body){
});

the above throws a TypeError

Possibly unhandled TypeError: Cannot call method 'get' of undefined
    at ret (eval at makeNodePromisifiedEval (....../node_modules/bluebird/js/main/promisify.js:177:12), <anonymous>:15:22)

however, if I modify it then it works

Promise.props({"url":"http:google.com"}).then(function(result){
return request.getAsync(result);
}).spread(function(response, body){
console.log(body);
});

[petkaantonov]

Because promisifyAll is also used to promisify modules and classes whose instances don't exist at promisification time, the methods cannot be bound to any particular this value even though in the singleton case (request, fs etc) that is possible. So they use whatever this is at call time, which is request when doing request.getAsync() but is undefined when doing var get = request.getAsync; get() as per how javascript this works.

So it would need to be an option to promisifyAll (e.g. promisifyAll(..., {singleton: true}))

[benjamingr]

@petkaantonov calling it a singleton is rather misleading (it's just a namespace and not really a singleton) - what about {bindContext: true}?

[jhnlsn]

Sorry fat thumbed thus on my phone.

[petkaantonov]

@johnymonster so what is your opinion? Would you use a bindContext option to be able to pass request.getAsync directly into a then?