Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on copy of separate ressource folders when post processing #11

Closed
AlexPiro opened this issue Dec 8, 2019 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@AlexPiro
Copy link
Contributor

AlexPiro commented Dec 8, 2019

When ressources are in separate folders, I get an error in the post processing function to copy files from tmp -> destination folder because folders don't exist.
I made this change in the src/gltf/writer.js (line. 183) to make this work :
for (const name of Object.getOwnPropertyNames(result.separateResources)) { fse.ensureDirSync(path.dirname(path.join(outputFolder, name))); fse.writeFileSync(path.join(outputFolder, name), result.separateResources[name]); }

@AlexPiro AlexPiro changed the title Separate ressource folders error when post processing Error on copy of separate ressource folders when post processing Dec 8, 2019
@petrbroz
Copy link
Owner

petrbroz commented Dec 9, 2019

Awesome, thanks @AlexPiro! Would you mind submitting a PR with the suggested code change?

@AlexPiro
Copy link
Contributor Author

AlexPiro commented Dec 9, 2019

I had this PR : #12

@petrbroz
Copy link
Owner

petrbroz commented Dec 9, 2019

Perfect, thanks so much!

@petrbroz petrbroz added the bug Something isn't working label Dec 9, 2019
@petrbroz
Copy link
Owner

petrbroz commented Dec 9, 2019

Fixed by @AlexPiro in #12.

@petrbroz petrbroz closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants