Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundancy #3

Closed
parshikov opened this issue Nov 7, 2013 · 6 comments
Closed

Reduce redundancy #3

parshikov opened this issue Nov 7, 2013 · 6 comments

Comments

@parshikov
Copy link
Contributor

We have got a small redundancy after merge #2. I propose to split the master branch into two independent parallel branches named Json and Yaml. After splitting one can use the branch they need.

@parshikov
Copy link
Contributor Author

Submodule system is based on a commit hash so no one should have difficult with this form of submodule.

@dustalov
Copy link
Member

dustalov commented Nov 8, 2013

Kinda interesting. @tanraya, @quozd, @thaumant?

@quozd
Copy link

quozd commented Nov 8, 2013

As for me, everything is fine with few rules files in the repo. What benefits will we get if we switch to branches? I can see only new difficulties with updating.

@thaumant
Copy link
Member

thaumant commented Nov 9, 2013

Аналогично, не вижу нужды увеличивать сложность в сторону разделения отдельных веток. Я бы предложил вносить все изменения в основной yml-файл, а json генерить автоматически, добавив таск для Rake, или что вы там в Ruby используете, чтобы любой разработчик, который внес изменения, мог дернуть его быстренько и пушнуть, не заморачиваясь.

@dustalov
Copy link
Member

dustalov commented Nov 9, 2013

Rakefile is added in 8a0371c. You can generate the JSON rules file rules.json by the rake command. I guess you're not required to install any additional Ruby libraries, just Ruby ≥ 1.9.

@parshikov
Copy link
Contributor Author

As I understand, we continue to maintain repository in current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants