Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of the settings.json file #47

Closed
Gorrrg opened this issue Jan 27, 2018 · 1 comment · Fixed by #63
Closed

Location of the settings.json file #47

Gorrrg opened this issue Jan 27, 2018 · 1 comment · Fixed by #63
Assignees

Comments

@Gorrrg
Copy link
Contributor

Gorrrg commented Jan 27, 2018

Currently the app expects the settings file to be in the same directory as the user is currently in, right? Isn't it better if the app looks in its own base directory instead?

I've run into this problem when writing a shell script that's traversing through directories, execution of app.py failed because of that. A dirty fix was to remember the current working directory and the file to be processed in a temporary variable, moving to the Twitch-Chat-Downloader directory for execution employing -o and then moving back again to the working directory both via the temporary variable.

Also an option "--settings" to point to an arbitrary settings file would be nice.

@PetterKraabol
Copy link
Owner

Currently working on a solution for this.

I will set the default path to ~/.tcd/settings.json with an optional --settings argument for custom paths.

PetterKraabol added a commit that referenced this issue Jan 9, 2019
Implemented #13, #47 and #56. Note: using helix video metadata, which lacks several v5 fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants