-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
battery-stats-collector
should just issue usable lines on stdout and no warning.
#23
Comments
I created a branch on my fork which propose a solution to the issue : b3/fork-battery-stats@7ea441d |
I do not think that the missing power supply should cause a cron email. In fact I am unsure that this message should be raised at all. Without power supply detection My idea for the proposition was that if the connected status (online or offline) can be detected it should be logged, but if it can not be detected that information shoud be logged too. That was why I proposed 3 states. I do not presuppose any use of that last information though. |
Right. make sense to me. |
Do you think my proposition should be integrated in your code? If yes I can just make a pull request of my demo branch. |
[Bruno BEAUFILS]
Yes. Please make a pull request. Happy hacking |
I have the same message in logs "No power supply found". |
In
battery-stats-collector
whenget_logline
is unable to determine a value forac_online
it echoes a message warning that "No power supply found". This line then goes to the log file before the status line is echoed.That way the generated file becomes unusable since every two lines it contains non-data. On my host it looks likes something like :
The warning line should not be echoed, or at least not on stdout.
The text was updated successfully, but these errors were encountered: