Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResizeObserver loop completed with undelivered notifications. #965

Closed
zebieksts opened this issue Aug 9, 2023 · 1 comment
Closed

ResizeObserver loop completed with undelivered notifications. #965

zebieksts opened this issue Aug 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@zebieksts
Copy link

Hi,
I am getting a lot of '_ResizeObserver loop completed with undelivered notifications.' errors when using react-virtuoso.
Issue is same as #254.
'RAF' fix, which you later reverted 5475a10 actually helps. I tried it and indeed errors went away. You mentioned that it was reverted because of scroll issues, but I have not noticed any. Long time has passed and perhaps scroll issues got fixed somehow.
Please consider re-applying 'RAF' fix.
Another idea to consider is making RAF optional via config option. Like:
options.useRafCallback ? requestAnimationFrame(() =>callback(element)) : callback(element);

@zebieksts zebieksts added the bug Something isn't working label Aug 9, 2023
@petyosi
Copy link
Owner

petyosi commented Aug 10, 2023

Time heals many things, but I'm afraid this problem is not one of them. If, however, the performance with RAF is acceptable for your case, feel free to maintain a fork - the project is fairly stable, so you're unlikely to have a hard time keeping up.

@petyosi petyosi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants