Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cut a release #178

Closed
kennethreitz opened this issue Feb 24, 2018 · 7 comments
Closed

cut a release #178

kennethreitz opened this issue Feb 24, 2018 · 7 comments

Comments

@kennethreitz
Copy link
Collaborator

No description provided.

@berdario
Copy link
Collaborator

berdario commented Mar 7, 2018

Can do, but I think that since the last release there haven't been meaningful changes beside test/setup improvements...

A big upcoming change is #173 but I need to get the Windows tests to pass, before merging that

@kennethreitz
Copy link
Collaborator Author

yeah this is low priority for us now, actually.

@berdario
Copy link
Collaborator

berdario commented Mar 7, 2018

Was this needed for pypa/pipenv#1474 ?

@uranusjr mentioned that it might be doable after a new pew release

I could release now, I but I see that you just bumped the version in setup.py to 1.1.4 from 1.1.3, is 1.1.4 ready for release and should we skip 1.1.3?

(A release for this project means a new annotated tag and the tarball/wheel uploaded to Pypi... I already added Erin as maintainer, so I'm fine with others releasing bugfix releases on Pypi... just let's make sure that the tag contains some brief release notes)

@berdario
Copy link
Collaborator

berdario commented Mar 7, 2018

I guess you might just have released a 1.1.3 to PPA for which pew cp was broken, and 1.1.4 fixes that... in which case, 1.1.4 has already been released over there.

So, this means that it'd be better to release the same versions (both of them) for upstream Pew, and not add any other small change to 1.1.4 (inconsistencies between the same versions could be really confusing).

@uranusjr
Copy link
Contributor

uranusjr commented Mar 7, 2018

Only thing needed on Pew’s part is the __main__ module. After that Pipenv needs to change all direct pew calls to python -m pew, and that’s all.

@kennethreitz
Copy link
Collaborator Author

Yeah, we're planning to proceed with that as soon as you cut a release, basically :)

@berdario
Copy link
Collaborator

I released 1.1.3, 1.1.4 and 1.1.5

(I uploaded only the Wheels to pypi, though... twine is having issues with uploading the tarballs 🤔 )

Sorry for the delay 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants