Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom attributeMap #355

Open
vorg opened this issue Nov 8, 2023 · 0 comments
Open

Add custom attributeMap #355

vorg opened this issue Nov 8, 2023 · 0 comments
Labels
Milestone

Comments

@vorg
Copy link
Member

vorg commented Nov 8, 2023

Currently to add custom attribute you do the following which mixes data creation with ctx webgl commands.

const corners = [...]
const cornersBuffer = graph.ctx.vertexBuffer({ data: new Float32Array(1)})
graph.ctx.update(cornersBuffer, { data: new Float32Array(g.corners.flat() )})
g.attributes = {
  aCorner: {
    buffer: cornersBuffer,
    divisor: 1
  },
   aCoords: {
    buffer: coordsBuffer,
    divisor: 1
  }
}

Ideally sth like that would be possible

g.corners = [...]
g.customAttributesMap = {
  aCorner: 'corners'
}
g.customInstancedAttributes: ['aCorner']

alternatively

g.corners = [...]
g.customAttributes = {
  aCorner: {
    attribute: 'corners',
    divisor: 1
  }
}
@dmnsgn dmnsgn added type/feat A new feature scope/ecs labels May 16, 2024
@dmnsgn dmnsgn modified the milestones: 4.0.0, 5.0.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants