Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gain maps #374

Open
2 tasks done
vorg opened this issue May 10, 2024 · 2 comments
Open
2 tasks done

Add support for gain maps #374

vorg opened this issue May 10, 2024 · 2 comments
Assignees
Labels
Projects
Milestone

Comments

@vorg
Copy link
Member

vorg commented May 10, 2024

https://gainmap-creator.monogrid.com

200MB exr -> 10MB jpg? Hell yeah!

Questions:

  • is gain map support pex-renderer, pex-shaders or lib-renderer feature?
  • can i resize the jpg and keep metadata? Does it still work? E.g. That 10MB jpg is 8k. Can i resize ldr jpg to 1024x512 and still get correct hdr? Resizing orignal hdr/exr is tricky without Photohop.
@dmnsgn dmnsgn self-assigned this May 13, 2024
@dmnsgn
Copy link
Member

dmnsgn commented May 16, 2024

Summary:

  • a pex-loaders feature, without any dependency other than a pex-context to recover the gainmap data
  • uses SRGB texture so WebGL1 support not guaranteed (but we're sunsetting it soon anyway)
  • resizing workflow without third party need clarifications
  • jpeg only for now
  • jpeg quality when exporting also yields further size decrease (huge drop in size from quality 1 to 0.9, possibly in the 5MB to 500kb) with little compromise on the env map quality.
  • I'd recommend we also agree on hdr file naming, including jpeg quality in the file naming: source-name-size-quality.ext eg. polyhaven-brown_photostudio_02-4096x2048-q90.jpg

Notes:

# Get jpeg image quality
identify -format '%Q' file.jpg

@dmnsgn dmnsgn added this to To do in 4.0.0 via automation May 22, 2024
@dmnsgn dmnsgn added this to the 4.0.0 milestone May 22, 2024
@vorg
Copy link
Member Author

vorg commented May 22, 2024

can i resize the jpg and keep metadata

No. You need to resize .hdr e.g. in Pixelmator and generate new gaim map

@vorg vorg added the high label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
4.0.0
  
To do
Development

No branches or pull requests

2 participants