Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --compile option is only useful for Python 2.7 #1939

Open
jsirois opened this issue Oct 6, 2022 · 0 comments
Open

The --compile option is only useful for Python 2.7 #1939

jsirois opened this issue Oct 6, 2022 · 0 comments
Labels

Comments

@jsirois
Copy link
Member

jsirois commented Oct 6, 2022

See here:
https://github.com/pantsbuild/pex/blob/322ab32c83b861ce1ca9c8372246635e7b7b58b4/pex/compiler.py#L24-L42

That's the old way of naming / placing pyc files. Python 3 will be looking under __pycache__ and miss: https://peps.python.org/pep-3147/

As such, for all but Python 2.7, PEXs built with --compile actually run slightly slower since there is just more dead weight to extract from the PEX.

@jsirois jsirois added the bug label Oct 6, 2022
This was referenced Oct 18, 2022
@jsirois jsirois mentioned this issue Nov 3, 2022
2 tasks
This was referenced Nov 21, 2022
@jsirois jsirois mentioned this issue Nov 28, 2022
2 tasks
This was referenced Dec 8, 2022
@jsirois jsirois mentioned this issue Jan 9, 2023
2 tasks
@jsirois jsirois mentioned this issue Jan 18, 2023
3 tasks
This was referenced Feb 12, 2023
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
@jsirois jsirois mentioned this issue Mar 23, 2023
2 tasks
@jsirois jsirois mentioned this issue Mar 30, 2023
2 tasks
This was referenced Apr 17, 2023
This was referenced May 1, 2023
@jsirois jsirois mentioned this issue May 13, 2023
2 tasks
@jsirois jsirois mentioned this issue Jul 1, 2023
3 tasks
This was referenced Jul 21, 2023
This was referenced Aug 3, 2023
@jsirois jsirois mentioned this issue Aug 12, 2023
1 task
This was referenced Aug 22, 2023
@jsirois jsirois mentioned this issue Sep 18, 2023
1 task
@jsirois jsirois mentioned this issue Sep 30, 2023
1 task
This was referenced Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant