Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider killing --rcfile option. #674

Open
jsirois opened this issue Feb 15, 2019 · 3 comments
Open

Consider killing --rcfile option. #674

jsirois opened this issue Feb 15, 2019 · 3 comments

Comments

@jsirois
Copy link
Member

jsirois commented Feb 15, 2019

The option only works at build-time and presents awkward semantic choices wrt PEX_IGNORE_RCFILES. Investigate why this option was added and kill it if the justification is weak or no longer pertinent.
@jsirois jsirois mentioned this issue Feb 15, 2019
Merged
@jsirois
Copy link
Member Author

jsirois commented Feb 15, 2019

Ok, added in #427 and, just like the option help says, really only to support a few integration tests. I'm pretty sure the flag can die and the integration tests be made to work in other ways.

@jsirois
Copy link
Member Author

jsirois commented Feb 15, 2019

@CMLivingston perhaps this is a better place to comment on the --rcfile awkwardness. Would you agree the option can die if the integration test can be made to work in other ways?

@CMLivingston
Copy link
Contributor

Absolutely, I agree that is is a weird interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsirois @CMLivingston