Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not show a large image #10

Closed
freimaks opened this issue Jun 7, 2017 · 5 comments
Closed

Does not show a large image #10

freimaks opened this issue Jun 7, 2017 · 5 comments
Assignees
Labels

Comments

@freimaks
Copy link

freimaks commented Jun 7, 2017

I have bug after update 5.3.0:

image 4

Why script.js has "require('./style.css')"?
image 5

@pexea12
Copy link
Owner

pexea12 commented Jun 7, 2017

Your first picture seems quite vague to me because the images look like corrupted. My guess is that you didn't include the vue-image-lightbox.min.css file as requirement.

The script.js has require('./style.css') because this css file is needed for the lightbox style. When building for production, I have already built a min css file in dist folder. Therefore, you only need to include this vue-image-lightbox.min.css.

@freimaks
Copy link
Author

freimaks commented Jun 7, 2017

@pexea12 But version 5.2.0 work in my project without this problem.

image

@pexea12
Copy link
Owner

pexea12 commented Jun 8, 2017

image

Things are fine with me. You should provide more information about the bug.
Were there any logs? Was the image loaded succesfully but not displayed correctly?
When you move to other images, can they be displayed correctly?

@freimaks
Copy link
Author

freimaks commented Jun 8, 2017

I found the error.

image

In .js:
"img",{key:t.imagesSrc[t.select].src,staticClass:"vue-lb-modal-image",attrs:{src:t.imagesSrc[t.select].src}})]

Instead of imagesSrc[t.select].src there should be images[t.select].src

@pexea12
Copy link
Owner

pexea12 commented Jun 9, 2017

I fixed it in 5.4.1. Please read the changelog carefully.

@pexea12 pexea12 closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants