Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES5 build #48

Closed
ondrej-janosik opened this issue Oct 12, 2018 · 9 comments
Closed

ES5 build #48

ondrej-janosik opened this issue Oct 12, 2018 · 9 comments

Comments

@ondrej-janosik
Copy link

Hi,

can you adjust babel so this lib produces ES5 compatible build? This is a nice lib but cannot be used when an app needs to support IE11.

Thanks, Ondrej.

@imcvampire
Copy link
Collaborator

Hi @ondrej-janosik, it already produces ES5 build! What is your problem when use it on IE11?

@ondrej-janosik
Copy link
Author

Are you sure? Because when I look into the distributed code, I can see object-shorthand, which is not supported by IE11.

image

@imcvampire
Copy link
Collaborator

Ah okay, thank you for the report! Let me see if I can do anything!

@ondrej-janosik
Copy link
Author

If you give me permission to create a PR, I have already fixed this issue locally. @imcvampire

@imcvampire
Copy link
Collaborator

imcvampire commented Oct 17, 2018

@ondrej-janosik I think you can create a PR anytime you like, you just have to fork this project and push your new code to the your repo and create a PR from it to this repo

@sven-ra
Copy link

sven-ra commented Mar 5, 2019

@ondrej-janosik Hello! How did you fix this locally?

@djvov
Copy link
Contributor

djvov commented Mar 13, 2019

I have already fixed this issue locally. @imcvampire

@ondrej-janosik Hello! How did you fix this?

@ondrej-janosik
Copy link
Author

ondrej-janosik commented Mar 14, 2019

Hi guys, if you use https://cli.vuejs.org/, you can use https://cli.vuejs.org/config/#transpiledependencies option. By default, babel-loader ignores all files inside node_modules. If you want to explicitly transpile this dependency with Babel, you can list it in this option. Otherwise, you can fork this library and adjust the babel settings https://github.com/pexea12/vue-image-lightbox/blob/master/.babelrc

@djvov @sven-ra

@djvov
Copy link
Contributor

djvov commented Mar 15, 2019

@ondrej-janosik

you can fork this library and adjust the babel settings

this works, thanks!

If you want to explicitly transpile this dependency with Babel, you can list it in this option.

which dependency I should wrote in this list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants