Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPLWrapTestCase.test_bash in 4.7.0 fails in openSUSE #568

Open
scarabeusiv opened this issue May 25, 2019 · 2 comments
Open

REPLWrapTestCase.test_bash in 4.7.0 fails in openSUSE #568

scarabeusiv opened this issue May 25, 2019 · 2 comments

Comments

@scarabeusiv
Copy link
Contributor

[ 156s] __________________________ REPLWrapTestCase.test_bash __________________________
[ 156s]
[ 156s] self = <tests.test_replwrap.REPLWrapTestCase testMethod=test_bash>
[ 156s]
[ 156s] def test_bash(self):
[ 156s] bash = replwrap.bash()
[ 156s] res = bash.run_command("alias")
[ 156s] > assert 'alias' in res, res
[ 156s] E AssertionError:
[ 156s] E assert 'alias' in ''

We have bash-5.0.7.1 present in the buildenviroment. Full log:
bash.txt

@scarabeusiv scarabeusiv changed the title REPLWrapTestCase.test_bash fails in openSUSE REPLWrapTestCase.test_bash in 4.7.0 fails in openSUSE May 25, 2019
@kulikjak
Copy link
Contributor

This just happened to us on Solaris as well. AFAICT the test case incorrectly assumes that there are always some set aliases, but that doesn't have to true.

The fix is either:

  1. choose a different build-in bash command
  2. call something like bash.run_command("alias a='b'") to make sure, that at least one alias exists.

@mtelka
Copy link

mtelka commented Sep 7, 2023

Similarly, the REPLWrapTestCase.test_bash_env test assumes there is PS1 always in the env output which is not the case, so the test could fail as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants