Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo #66

Closed
wants to merge 1 commit into from
Closed

fixed typo #66

wants to merge 1 commit into from

Conversation

Nystrex
Copy link

@Nystrex Nystrex commented Apr 29, 2021

No description provided.

@takluyver
Copy link
Member

Thanks, but these are all questions of style rather than mistakes, and in 2/3 cases I like what's already there better. I'd accept 'command-line' over 'command line' if you want to make a PR for that alone, though even there it's not really a typo.

(Just in case you're motivated by seeing that this is one of the qualifying repositories for the Mars helicopter badge, I don't think new contributrors will get the badge. I believe Github only looked at commits before the badge was created.)

@takluyver takluyver closed this Apr 30, 2021
@Nystrex
Copy link
Author

Nystrex commented Apr 30, 2021

(Just in case you're motivated by seeing that this is one of the qualifying repositories for the Mars helicopter badge, I don't think new contributrors will get the badge. I believe Github only looked at commits before the badge was created.)

Hahaha, yeah I tried to cheat the system, thanks for clarifying that the badge isn't available for new contributors. 😅

@Nystrex Nystrex deleted the patch-1 branch April 30, 2021 13:33
@Red-M
Copy link
Member

Red-M commented Apr 30, 2021

I want to make a small comment about this badge and why GitHub probably handed them out (since we're probably going to see more of them come up at some point).

I think if you're just trying to get a badge, its missing half the point of this badge in particular (and probably (some of the) ones in the future).

The point isn't to get a badge, its that you helped with something in the OSS community, so if you want more of these kinds things, be active in the community with either your own project or someone else's project and you'll get this kind of recognition. I'd hate to see GitHub drop these kinds of events, due to behaviour similar to how the month of code event went on with people spamming PRs for shirts... again...

@takluyver
Copy link
Member

Yeah, I wouldn't be surprised if the Hacktoberfest snafu fed into their thinking about how to manage the badges, awarding them only based on commits before the badge was created.

It's not a great way to reward people - it's easy to miss out hidden dependencies (like pip itself, which is mentioned in the fprime install docs), and if they make badges more often, it might just lead to people spraying low-effort PRs around many different repositories in the hope of picking up future badges. But I won't deny that the Mars helicopter badge is a pretty cool thing to get. 😄

@Red-M
Copy link
Member

Red-M commented Apr 30, 2021

I think its less about reward and about showing who actually makes contributions.
I know this will sound cheesy but, the reward is knowing you helped out to make things just a little bit better for other people.
Its a bad reward because its not a reward and its recognising people who put the effort in when no one is asking for it (although the pip devs/contributors missing out is a little strange :( ).

Anyway, for anyone else reading this, OSS is great and people should take (more of) an interest (there are people behind those weird credits in your iP(od|hone))!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants