-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an unit test #26
Comments
Hi, I am table to take a look at this. Is there anything I should know before dealing with this issue? |
The main issue is that everything in the main file, https://github.com/Pext/Pext/blob/master/pext/pext.py, is very tangled up with the rather huge Window class at https://github.com/Pext/Pext/blob/master/pext/pext.py#L1689-L2248. You will see functions in every class starting with the word "bind" which is generally where things are coupled to the Window class (either there or the constructor already). So it is likely you'll have to figure out how to decouple some things with the Window class so they can be tested without actually opening a window. This issue is just as much about cleaning the code so it becomes more testable than writing an actual issue test and probably one of the hardest issues (unless you're good at refactoring). |
I see, I think the task is clear for now. Please assign me to this issue |
Unfortunately, I can't seem to assign you because you haven't collaborated before and aren't in a team: https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/. I'm inviting you to an "Hacktoberfest" team to try to work around this weird design, will assign you then. |
Okay, assigned :) |
Hey, it's been 2 weeks, just poking to ask if you managed to make any progress and what your plan for this is :) |
With @ata2001's recent contributions, I consider this issue good to close. Of course, more tests are a great idea, but this is a great start, and we have a test now :) |
Pext is a beast which has a WAY too big coupling to the Window class in the Python code. Preferably, the added unit test would come along with a decreased coupling that everything has the Window class, but any useful unit test would be great.
The text was updated successfully, but these errors were encountered: