Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiobrowser gives weird terminal dump without a force unload or crash #60

Closed
kozross opened this issue Dec 30, 2017 · 1 comment
Closed
Labels
Milestone

Comments

@kozross
Copy link
Contributor

kozross commented Dec 30, 2017

Is this a bug or a feature request?

Bug.

What Pext version are you running?

Pext v0.11.1-19-g4ca9d49 (according to pext --version)

What OS are you using? (e.g.: Ubuntu 16.04, Windows 10, macOS High Sierra)

Arch Linux.

If this is a bug:

What did you do to run into this bug, step-by-step?
  1. Start Pext in the terminal and load radiobrowser
  2. Start some music playin'
  3. Go to 'By Most Tune-Ins' (I think - I don't exactly recall what triggered this)
  4. Observe this lovely dump in your terminal
[koz@Sebastian ~]$ pext
python3-opengl is not installed. If Pext fails to render, please try installing it. See https://github.com/Pext/Pext/issues/11.
Using locale: en_NZ 
Localization loaded: True
python3-opengl is not installed. If Pext fails to render, please try installing it. See https://github.com/Pext/Pext/issues/11.
Using locale: en_NZ 
Localization loaded: True
WARN: Module radiobrowser uses old process_response signature and will not be able to receive an identifier if requested
WARN: Module radiobrowser caused exception list index out of range
Counting objects: 59, done.
Total 59 (delta 0), reused 0 (delta 0), pack-reused 59
Checking out HEAD
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/pext/__main__.py", line 593, in run
    self._process_tab_action(tab, active_tab)
  File "/usr/lib/python3.6/site-packages/pext/__main__.py", line 554, in _process_tab_action
    tab['vm'].context_menu_base = action[1]
IndexError: list index out of range

This did not force a module unload or crash Pext - music kept playing.

What did you expect would happen?

Terminal spew not occur, especially indicating out-of-range issues.

What actually happened?

See note above.

Is there anything else you would like to add?

No.

@TheLastProject
Copy link
Member

Should've been fixed in dc9622d

@TheLastProject TheLastProject added this to the v1.0 milestone Dec 31, 2017
@TheLastProject TheLastProject modified the milestones: v1.0, v0.11, v0.12 Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants