Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/cpu/arm_thumb: Condition codes in b.w don't appear to be decoded #23

Closed
pfalcon opened this issue Jun 5, 2017 · 3 comments
Closed

Comments

@pfalcon
Copy link
Owner

pfalcon commented Jun 5, 2017

Example of disasm:

│08020036          nlr_jump:                                                                                                           │
│08020036 0d4b         ldr      r3, [pc, #52]                                                                                          │
│08020038 1a68         ldr      r2, [r3, #0]                                                                                           │
│0802003a 002a         cmp      r2, #0                                                                                                 │
│0802003c 0df0de83     b.w      nlr_jump_fail                                                                                          │
│08020040 50           unk     0x50 ; 'P'                                                                                              │
│08020041 60           unk     0x60 ; '`'                                                                                              │
│08020042 10           unk     0x10                                                                                                    │
│08020043 68           unk     0x68 ; 'h'                                                                                              │
│08020044 18           unk     0x18                                                                                                    │
│08020045 60           unk     0x60 ; '`'                                                 

That b.w can't be right, should be conditional.

(Disassembling MicroPython's bare-arm port.)

@pfalcon
Copy link
Owner Author

pfalcon commented Jun 5, 2017

@dpgeorge, @flowergrass : FYI

@pfalcon
Copy link
Owner Author

pfalcon commented Jun 5, 2017

Another issue:

objdump:

 8020504:       f7ff bde6       b.w     80200d4 <m_free>

vs

08020504 fff7e6bd     b.w      0xa0200d4       

@pfalcon
Copy link
Owner Author

pfalcon commented Jun 23, 2017

Tracked in #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant