Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-secret.svg replacing default avatar? #178

Open
asuh opened this issue May 28, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@asuh
Copy link

commented May 28, 2018

While I don't mind that this plugin offers its own avatar for unassigned gravatar photos, I wish it would present me the option to choose it on wp-admin/options-discussion.php under Default Avatar. With the latest update, all my default avatars are being overridden with user-secret.svg.

@dshanske

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2018

I will fix this one. My condition was overly broad

@dshanske

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2018

@asuh The reason for the avatar being offered was that most webmentionms don't have an email address attached to them. That means gravatar is essentially useless. The way WordPress is designed, even if there is no email address, which is what gravatar uses, it goes out to gravatar to retrieve the avatar image...including the default images and anything you set in the avatar default selection option under Default Avatar.

The bundled icon is served locally. But it should only be done if you select that as an option under default avatar.

@dshanske

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2018

Maybe I should at the same time look at #6 which I have been wanting since 2014.

@dshanske

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2018

@asuh #180 attempts to resolve this. It only does this behavior if selected.

@asuh

This comment has been minimized.

Copy link
Author

commented May 31, 2018

@dshanske awesome, when this gets merged and updated, I'll give it a whirl and see what happens.

What you're saying about webmentions makes sense. I also agree that #6 would be great to couple with this.

@dshanske

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2018

Addressed in latest commit, coming to stable soon.

@chrisaldrich

This comment has been minimized.

Copy link

commented Jul 25, 2018

In version 3.8.1 it currently appears that comments from WordPress and Micro.blog (both of which have Gravatar as a commonality) appear to be automatically using the default mystery person avatar even though there is a separate avatar defined within the Avatar fields for Semantic Linkbacks Data.

If I add my my email address within the comment editing interface, then the appropriate Gravatar is pulled and displayed as expected. This leads me to believe that somehow SL either isn't finding/pulling the Gravatar URL that it's storing, or the code is potentially skipping looking for it within its logic structure.

I've noticed this also seems to be the case for other WP sites which I have reason to suspect are running this same version as well.

Webmentions from other non-Gravatar related sites don't seem to be affected by this and they're displaying the proper avatar images as defined within their h-cards.

(Originally published at: https://boffosocko.com/2018/07/25/mystery-person-default-overriding-semantic-linkbacks-defined-gravatar/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.