Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Checked facepile settings aren't actually active #240

Closed
prtksxna opened this issue Apr 7, 2020 · 6 comments
Closed

Checked facepile settings aren't actually active #240

prtksxna opened this issue Apr 7, 2020 · 6 comments

Comments

@prtksxna
Copy link

prtksxna commented Apr 7, 2020

On a fresh WordPress install when you install only this plugin (no WebMention or any other plugin) and go to the Discussions settings, under Automatically embed facepiles, you see this:

Screenshot 2020-04-07 at 4 38 14 PM

But if you do a var_dump of get_option( 'semantic_linkbacks_facepiles', array() ); you get an empty array and so no facepiles are shown.

As a user I fixed this by unchecking Reacji and saving the settings. This made facepiles show up. I then checked Reacji again and saved, and the facepiles are still showing since the settings aren't empty any more.

This might be related to #237 and #227

@pfefferle
Copy link
Owner

OK, then it is a problem with default settings

@pfefferle
Copy link
Owner

@prtksxna thanks for debugging! can you verify my change?

@prtksxna
Copy link
Author

prtksxna commented Apr 7, 2020

Thank you for such a quick fix 🔥
Sure, I'll spin up a new instance tomorrow and let you know 😊

@pfefferle
Copy link
Owner

cool, thanks!

@prtksxna
Copy link
Author

prtksxna commented Apr 9, 2020

Works! Thank you again @pfefferle.

@pfefferle
Copy link
Owner

Thanks for testing! I released the new version with that fix: https://github.com/pfefferle/wordpress-semantic-linkbacks/releases/tag/3.10.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants