Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parameter for init_state in heston process #395

Closed
masanorihirano opened this issue Nov 9, 2021 · 6 comments · Fixed by #401
Closed

Default parameter for init_state in heston process #395

masanorihirano opened this issue Nov 9, 2021 · 6 comments · Fixed by #401

Comments

@masanorihirano
Copy link
Collaborator

https://pfnet-research.github.io/pfhedge/stochastic.html#pfhedge.stochastic.generate_heston

I think (1.0, sigma**2) is better for init_state.
Thus, how about changing the default of init_state to None and calculating them in this method.

@ghost
Copy link

ghost commented Nov 9, 2021

Sounds good! I think theta would be the best.

@masanorihirano
Copy link
Collaborator Author

Oh, you're right.

But, I think the best setting is sigma**2 = theta = V(0).
It seems a little complicated.
What's the best solution for it?

@ghost
Copy link

ghost commented Nov 9, 2021

Only V(0) = theta would suffice? I may be missing something and don't see a reason to impose sigma**2 = theta. sigma is the volatility of V and is not necessarily assumed to be related to the value of V itself.

By the way, generate_cir may also need a similar update.

update: typo

@masanorihirano
Copy link
Collaborator Author

I was wrong.

I was confused that sigma means volatility, but correctly it is vol. of vol.

Thus, Only V(0) = theta is OK.

@ghost
Copy link

ghost commented Nov 9, 2021

I will accept a pr!

@masanorihirano
Copy link
Collaborator Author

I'll make a pr later. (It could be next week.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant