Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratios of the input and output images are different #53

Closed
liamjones opened this issue Jan 31, 2017 · 1 comment
Closed

Aspect ratios of the input and output images are different #53

liamjones opened this issue Jan 31, 2017 · 1 comment

Comments

@liamjones
Copy link
Contributor

The output image used to have the same aspect ratio as the input image in the original version, since then a change has resulted in the output image being squished.

I believe the cause was this code removal: 963e2da#diff-bfd7a84bc84a48c1888381141bfa873b

I'm not certain if it should be JavaScript that goes back in as the fix though. If it did, the webpage display would be correct but users downloading the output image would save one with the wrong aspect ratio.

Potentially better solution; the server side code does a final image resize back to the original aspect ratio when it's finished processing. This way if someone downloads the output image the aspect ratio will be same as the original (even if the image is now smaller).

@taizan
Copy link
Contributor

taizan commented Feb 1, 2017

It is needed to resize the input image to multiple of 16 otherwse, NN will crush...
so server side resize is better but its a little bit cpu cost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants