Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lstm dropout #2504

Merged
merged 2 commits into from Apr 11, 2017
Merged

Fix lstm dropout #2504

merged 2 commits into from Apr 11, 2017

Conversation

unnonouno
Copy link
Member

I fixed dropout policy on NStepLSTM. It is compatible with cuDNN's one. To check it I made a test to count dropout applied.

@unnonouno unnonouno added cat:bug Bug report or fix. cat:test Test or CI related. labels Apr 5, 2017
@soskek
Copy link
Member

soskek commented Apr 10, 2017

LGTM

@okuta okuta added this to the v1.24.0 milestone Apr 11, 2017
@okuta
Copy link
Member

okuta commented Apr 11, 2017

Thank you for your checking @soskek

@okuta okuta merged commit e049cc4 into master Apr 11, 2017
@okuta okuta deleted the fix-lstm-dropout branch April 11, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cat:bug Bug report or fix. cat:test Test or CI related.
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unnonouno @soskek @okuta