Add reduce option to decov #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnonouno
requested changes
May 7, 2017
chainer/functions/loss/decov.py
Outdated
| cost = xp.vdot(self.covariance, self.covariance) * h.dtype.type(0.5) | ||
| return utils.force_array(cost), | ||
| if self.reduce == 'half_frobenius_norm': | ||
| cost = xp.vdot(self.covariance, self.covariance) |
There was a problem hiding this comment.
Is sqrt required for frobenius norm, isn't it?
There was a problem hiding this comment.
Ah, yes. I think it is better to provide squared norm (like MSE). So, I change the option to 'half_squared_frobenius_norm'.
| Args: | ||
| h (Variable): Variable holding a matrix where the first dimension | ||
| corresponds to the batches. | ||
| recude (str): Reduction option. Its value must be either |
| loss_shape = () | ||
| else: | ||
| loss_shape = (3, 3) | ||
| self.assertEqual(loss.data.shape, loss_shape) |
unnonouno
requested changes
May 8, 2017
chainer/functions/loss/decov.py
Outdated
| @@ -10,9 +10,14 @@ class DeCov(function.Function): | |||
|
|
|||
| """DeCov loss (https://arxiv.org/abs/1511.06068)""" | |||
|
|
|||
| def __init__(self): | |||
| def __init__(self, reduce='half_squared_frobenius_norm'): | |||
unnonouno
approved these changes
May 8, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
reduceoption toF.DecovandF.decov. Related to #2558