Word2vec example #270
Merged
Word2vec example #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll release this PR without GPU mode (#264). GPU mode will be supported in 1.2.0. |
|
Although this PR is added to v1.1.2 Milestone, it must be preceded by #264, which is a feature PR. |
|
No, I removed #264 from this PR. It can work with HSM (only CPU), NS(both CPU and GPU), original (both CPU and GPU). |
|
@unnonouno OK, I understand it. |
|
|
||
| index2word = {} | ||
| word2index = {} | ||
| counts = collections.defaultdict(lambda: 0) |
There was a problem hiding this comment.
int can be used instead of lambda: 0. You can also use collections.Counter.
|
LGTM except two comments! |
|
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented word2vec example including skip-gram architecture and continuous-bow architecture with HSM and negative sampling.
Note that this implementation is slower than the original even when you use GPU.
Please review this PR after #264