Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctc padding #689

Merged
merged 14 commits into from Mar 1, 2016
Merged

Add ctc padding #689

merged 14 commits into from Mar 1, 2016

Conversation

jnishi
Copy link
Contributor

@jnishi jnishi commented Nov 26, 2015

Support padding for training CTC with mini batch. Using this, you can train CTC by training data that are different length.

If valid length of each inputs of batch are given, values of input array after the given length are ignored.

@unnonouno unnonouno added the cat:feature Implementation that introduces new interfaces. label Dec 2, 2015
@unnonouno unnonouno added this to the v1.6.0 milestone Dec 2, 2015
@jnishi
Copy link
Contributor Author

jnishi commented Dec 18, 2015

I support padding and its computation is all on GPU. Please check.

@jnishi
Copy link
Contributor Author

jnishi commented Dec 22, 2015

Add test case for the case which all of inputs are padded.

@okuta okuta added the no-compat Change that disrupts backward compatibility. label Jan 5, 2016
@unnonouno unnonouno removed this from the v1.6.0 milestone Jan 5, 2016
@okuta okuta removed the no-compat Change that disrupts backward compatibility. label Jan 5, 2016
@okuta okuta self-assigned this Jan 5, 2016
@okuta okuta added this to the v1.6.0 milestone Jan 5, 2016
@okuta okuta removed this from the v1.6.0 milestone Jan 19, 2016
Jiro Nishitoba added 3 commits February 16, 2016 11:48
fixes _make_inputs.
Conflicts:
	tests/chainer_tests/functions_tests/loss_tests/test_ctc.py
…into okuta-fix-add-ctc-padding

Conflicts:
	chainer/functions/loss/ctc.py
@unnonouno unnonouno added this to the v1.7.0 milestone Feb 22, 2016
@okuta
Copy link
Member

okuta commented Mar 1, 2016

LGTM!

okuta added a commit that referenced this pull request Mar 1, 2016
@okuta okuta merged commit a76abe1 into chainer:master Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:feature Implementation that introduces new interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants