Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TPESampler faster. #466

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Make TPESampler faster. #466

merged 5 commits into from
Jul 31, 2019

Conversation

oda
Copy link
Contributor

@oda oda commented Jul 30, 2019

Hi,
I wrote a simple patch to refactor TPE.
It approximately makes the speed of TPE 10 times faster and makes it easier to read.
When using TPE for 10,000 trials with two parameters, it used to take 2 hours, but with this, it takes less than 15 minutes.

@sile sile added this to the v0.14.0 milestone Jul 30, 2019
@sile sile added the enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. label Jul 30, 2019
@c-bata c-bata mentioned this pull request Jul 30, 2019
2 tasks
Copy link
Member

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thank you.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirmed that this PR does not affect the optimization performance in term of the best-found values of 38 benchmark functions. For further details of the experiment, please refer to this article.

Thank you for your contribution!

@toshihikoyanase toshihikoyanase merged commit e997230 into optuna:master Jul 31, 2019
@sile sile changed the title Make tpe faster Make TPESampler faster Aug 1, 2019
@g-votte g-votte changed the title Make TPESampler faster Make TPESampler faster. Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Change that does not break compatibility and not affect public interfaces, but improves performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants