Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cget with cmake v3.14.0 #72

Closed
jonathonl opened this issue Mar 22, 2019 · 4 comments
Closed

cget with cmake v3.14.0 #72

jonathonl opened this issue Mar 22, 2019 · 4 comments

Comments

@jonathonl
Copy link

Has cget been tested with cmake v3.14.0? All of my cget installs fail with this version of cmake, but not with earlier versions like v3.5.1 and v3.8.1. The problem is that the cget/include directory is not being set as an include directory for the project being built.

@jonathonl
Copy link
Author

To clarify, this happens when the project being built depends on another project that was installed by cget via a requirements.txt file.

@jonathonl
Copy link
Author

I believe this is actually a bug in cmake, so I created an issue with them as well and provided a test case.

https://gitlab.kitware.com/cmake/cmake/issues/19079

@jonathonl
Copy link
Author

The CMake maintainers warn against using include_directories() in toolchain files. They suggest using CMAKE_{C,CXX}_STANDARD_INCLUDE_DIRECTORIES instead.

@pfultz2
Copy link
Owner

pfultz2 commented Mar 23, 2019

Thanks for the info. I'll update the toolchain. Although for older cmake version it will still need to use include_directories() since this variable was introduced in 3.6.

@pfultz2 pfultz2 closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants