Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qoi-fu doesn't work correctly for encoding 4 channels images #13

Closed
wx257osn2 opened this issue Jan 12, 2024 · 4 comments
Closed

qoi-fu doesn't work correctly for encoding 4 channels images #13

wx257osn2 opened this issue Jan 12, 2024 · 4 comments
Assignees

Comments

@wx257osn2
Copy link

wx257osn2 commented Jan 12, 2024

Current qoi-fu works not same as reference QOI implementation only if encoding 4 channels images.
The size of output by qoi-fu is bigger than one by reference.

Please see more information on my test repo.

@pfusik pfusik self-assigned this Jan 12, 2024
@pfusik
Copy link
Owner

pfusik commented Jan 12, 2024

Where are the test PNG files?

@wx257osn2 wx257osn2 changed the title qoi-fu doesn't works correctly for encoding 4 channels images qoi-fu doesn't work correctly for encoding 4 channels images Jan 13, 2024
@wx257osn2
Copy link
Author

Where are the test PNG files?

They are from qoi_benchmark_suite.tar.

@pfusik pfusik closed this as completed in 4870739 Jan 13, 2024
@pfusik
Copy link
Owner

pfusik commented Jan 13, 2024

Thank you very much for reporting this!
It was a suboptimal compression which affected some images, regardless of the alpha channel.
I will make a binary release in a week or so.

@wx257osn2
Copy link
Author

I confirmed that the issue was solved. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants